Re: [Qemu-devel] [PATCH v5 03/17] qio: Create new qio_channel_{readv, writev}_all

[Daniel P. Berrange]

On Wed, Jul 19, 2017 at 05:04:19PM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (address@hidden) wrote:
> > On Wed, Jul 19, 2017 at 04:42:09PM +0100, Dr. David Alan Gilbert wrote:
> > > * Juan Quintela (address@hidden) wrote:
> > > > The functions waits until it is able to write the full iov.
> > > 
> > > When is it safe to call these - I see qio_channel_wait does it's
> > > own g_main_loop - so I guess they're intended to be called from their
> > > own process?
> > > 
> > > What causes these to exit if the migration fails for some other
> > > (non-file) related reason?
> > 
> > It'll exit if the other end closes the socket, or if the local QEMU
> > does a qio_channel_close() on it.  I don't know if this patch series
> > uses either of those options tough.
> 
> How do you safely cope with calling close on a socket that's currently
> being waited on/might be reading?  In the cancel case we use shutdown()
> to force exits with out actually closing.

You can use qio_channel_shutdown() instead if that's desired

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|