qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/11] qtest.py: Few pylint/style fixes


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 10/11] qtest.py: Few pylint/style fixes
Date: Thu, 20 Jul 2017 15:42:11 -0300
User-agent: Mutt/1.8.0 (2017-02-23)

On Thu, Jul 20, 2017 at 06:28:14PM +0200, Lukáš Doktor wrote:
[...]
> @@ -83,8 +80,11 @@ class QEMUQtestMachine(qemu.QEMUMachine):
>                   socket_scm_helper=None):
>          if name is None:
>              name = "qemu-%d" % os.getpid()
> -        super(QEMUQtestMachine, self).__init__(binary, args, name=name, 
> test_dir=test_dir,
> -                                               
> socket_scm_helper=socket_scm_helper)
> +        scm_helper = socket_scm_helper

Why is this necessary?

> +        super(QEMUQtestMachine, self).__init__(binary, args, name=name,
> +                                               test_dir=test_dir,
> +                                               socket_scm_helper=scm_helper)
> +        self._qtest = None
>          self._qtest_path = os.path.join(test_dir, name + "-qtest.sock")
>  
>      def _base_args(self):
> -- 
> 2.9.4
> 

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]