|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [RFC PATCH for 2.11 15/23] target/arm/translate-a64.c: AdvSIMD scalar 2 register misc decode |
Date: | Thu, 20 Jul 2017 09:49:23 -1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/20/2017 05:04 AM, Alex Bennée wrote:
+ for (pass = 0; pass < elements; pass++) { + TCGv_i32 tcg_op1 = tcg_temp_new_i32(); + TCGv_i32 tcg_res = tcg_temp_new_i32(); + + read_vec_element_i32(s, tcg_op1, rn, pass, MO_16); + + switch (fpopcode) { + default: + fprintf(stderr,"%s: insn %#04x fpop %#2x\n", __func__, insn, fpopcode); + unsupported_encoding(s, insn); + }
Just noticing that we ought not issue N copies of the unsupported_encoding exception. Return afterwards seems in order. Is this a pattern that you copied that wants fixing elsewhere?
r~
[Prev in Thread] | Current Thread | [Next in Thread] |