qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH for 2.11 03/23] softfloat3c: dos2unix all fi


From: Alex Bennée
Subject: Re: [Qemu-devel] [RFC PATCH for 2.11 03/23] softfloat3c: dos2unix all files
Date: Fri, 21 Jul 2017 09:56:23 +0100
User-agent: mu4e 0.9.19; emacs 25.2.50.3

Thomas Huth <address@hidden> writes:

> On 20.07.2017 20:59, Richard Henderson wrote:
>> On 07/20/2017 05:04 AM, Alex Bennée wrote:
>>> This is a massive but mechanical patch, the result of:
>>>
>>>    (cd fpu/softfloat3c; and find . | xargs dos2unix)
>>>    (cd include/fpu/softfloat3c; and dos2unix *)
>>>
>>> Signed-off-by: Alex Bennée<address@hidden>
>>> ---
>>
>> Really shouldn't this have been part of the import?
>
> +1
> It's only a whitespace change, so please squash it in the previous patch
> instead. (You could mention this in the patch description that line
> endings have been changed to unix mode)

Sure - I just wanted to be clear of the steps I took should I want to do
it from scratch again.

One thing playing in my mind against moving to SoftFloat3c is the
inscrutability of the upstream. It's nice there has been a new release
with new features but there isn't a source repository or as far as I can
tell a development list. It is basically as far as I can tell a one man
project albeit backed by academic funding.

That said the license change in 3 does mean it would be a lot easier to
incorporate fixes and updates if and when upstream release new versions.

--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]