Re: [Qemu-devel] [RFC PATCH for 2.11 03/23] softfloat3c: dos2unix all files

[Aurelien Jarno]

On 2017-07-21 10:27, Daniel P. Berrange wrote:
> On Fri, Jul 21, 2017 at 09:56:23AM +0100, Alex Bennée wrote:
> > 
> > Thomas Huth <address@hidden> writes:
> > 
> > > On 20.07.2017 20:59, Richard Henderson wrote:
> > >> On 07/20/2017 05:04 AM, Alex Bennée wrote:
> > >>> This is a massive but mechanical patch, the result of:
> > >>>
> > >>>    (cd fpu/softfloat3c; and find . | xargs dos2unix)
> > >>>    (cd include/fpu/softfloat3c; and dos2unix *)
> > >>>
> > >>> Signed-off-by: Alex Bennée<address@hidden>
> > >>> ---
> > >>
> > >> Really shouldn't this have been part of the import?
> > >
> > > +1
> > > It's only a whitespace change, so please squash it in the previous patch
> > > instead. (You could mention this in the patch description that line
> > > endings have been changed to unix mode)
> > 
> > Sure - I just wanted to be clear of the steps I took should I want to do
> > it from scratch again.
> > 
> > One thing playing in my mind against moving to SoftFloat3c is the
> > inscrutability of the upstream. It's nice there has been a new release
> > with new features but there isn't a source repository or as far as I can
> > tell a development list. It is basically as far as I can tell a one man
> > project albeit backed by academic funding.
> 
> This is no worse than the situation we already have with SoftFloat 2
> though is it. IOW, as long as we fully move from v2 -> v3 eventually
> (to avoid maintaining both indefinitely) we're no worse off from the
> community POV. At least v3 has the possibility to be become more
> community driven in future, where as v2 is essentially now a obsolete
> version.

It depends if we are able to get (at least part of) our changes
upstreamed. Switching to softfloat v3 is likely to be a substantial
effort, and we probably don't want to have the same discussion and do
this effort again when switching to softfloat v4. Now if we are able to
get our changes upstream, switching to softfloat v4 will be much easier.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net