[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] tests: Pass literal format strings directly
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] tests: Pass literal format strings directly to qmp_FOO() |
Date: |
Fri, 21 Jul 2017 09:26:57 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/21/2017 08:53 AM, Markus Armbruster wrote:
> The qmp_FOO() take a printf-like format string. In a few places, we
> assign a string literal to a variable and pass that instead of simply
> passing the literal. Clean that up.
>
> Bonus: gets rid of non-literal format strings. A step towards
> compile-time format string checking without triggering
> -Wformat-nonliteral.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/ahci-test.c | 4 +---
> tests/ide-test.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/9] tests: Clean up around qmp() and hmp(), Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 1/9] qtest: Avoid passing raw strings through hmp(), Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 3/9] tests: Pass literal format strings directly to qmp_FOO(), Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 8/9] tests/libqtest: Clean up how we read the QMP greeting, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 5/9] tests/libqos/usb: Clean up string interpolation into QMP input, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 7/9] tests: Clean up wait for event, Markus Armbruster, 2017/07/21