[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v14 03/34] target/i386: Use generic DISAS_* enum
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH v14 03/34] target/i386: Use generic DISAS_* enumerators |
|
Date: |
Fri, 21 Jul 2017 17:25:41 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Jul 14, 2017 at 23:42:12 -1000, Richard Henderson wrote:
> This target is not sophisticated in its use of cleanups at the
> end of the translation loop. For the most part, any condition
> that exits the TB is dealt with by emitting the exiting opcode
> right then and there. Therefore the only is_jmp indicator that
> is needed is DISAS_NORETURN.
>
> For two stack segment modifying cases, we have not yet exited
> the TB (therefore DISAS_NORETURN feels wrong), but intend to exit.
> The caller of gen_movl_seg_T0 currently checks for any non-zero
> value, therefore DISAS_TOO_MANY seems acceptable for that usage.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Emilio G. Cota <address@hidden>
E.
- [Qemu-devel] [PATCH v14 00/34] Generic translation framework, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 02/34] tcg: Add generic DISAS_NORETURN, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 01/34] Pass generic CPUState to gen_intermediate_code(), Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 03/34] target/i386: Use generic DISAS_* enumerators, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 04/34] target/arm: Use DISAS_NORETURN, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 06/34] target/arm: Delay check for magic kernel page, Richard Henderson, 2017/07/15
- [Qemu-devel] [PATCH v14 07/34] target/arm: Set is_jmp properly after single-stepping, Richard Henderson, 2017/07/15