Re: [Qemu-devel] [PATCH v14 30/34] target/arm: [tcg] Port to generic translation framework

[Emilio G. Cota]

On Fri, Jul 21, 2017 at 19:02:58 -0400, Emilio G. Cota wrote:
> On Fri, Jul 14, 2017 at 23:42:39 -1000, Richard Henderson wrote:
> > From: Lluís Vilanova <address@hidden>
> > 
> > Signed-off-by: Lluís Vilanova <address@hidden>
> > Message-Id: <address@hidden>
> > Signed-off-by: Richard Henderson <address@hidden>
> > ---
> >  target/arm/translate.h     |   8 +---
> >  target/arm/translate-a64.c | 107 
> > ++++++++-----------------------------------
> >  target/arm/translate.c     | 110 
> > ++++++++++-----------------------------------
> >  3 files changed, 42 insertions(+), 183 deletions(-)
> 
> (snip)
> > diff --git a/target/arm/translate.c b/target/arm/translate.c
> > index 4ea5f70..4b1230b 100644
> > --- a/target/arm/translate.c
> > +++ b/target/arm/translate.c
> > @@ -11897,7 +11897,9 @@ static void arm_tr_tb_start(DisasContextBase 
> > *dcbase, CPUState *cpu)
> >          TCGv_i32 tmp = tcg_temp_new_i32();
> >          tcg_gen_movi_i32(tmp, 0);
> >          store_cpu_field(tmp, condexec_bits);
> > +        tcg_temp_free_i32(tmp);
> 
> This seems unrelated to the patch. Perhaps a better place to add
> this fix would be patch 20, with a mention to it in the commit log.
> Or just keep it here, but mention it in the commit log.

Silly me. This must go away, because store_cpu_field already
frees the temp.

                E.