Re: [Qemu-devel] [PATCH 2/3] Unified Datagram Socket Transport - GRE support

[Anton Ivanov]

> > ##
> >
> > If I read this right port is mandatory, correct?
> Okay, so it sounds like reusing InetSocket directly may not be possible.
>   But there's still the interface question of whether we want dual 'ipv4'
> and 'ipv6' switches to allow finer-grain control over which (or both)
> families to be used.

I have that in the new version ready for submission. Behavior is 
identical with other arguments which have a v4 and v6 switch.

> > We may be able to do it if the port portion if InetSocketAddress becomes
> > optional. There is no such thing as port for the protocols which use the
> > raw families.
> We can always create a new QAPI type that expresses only the fields we
> need; I don't think InetSocketAddress should be changed to have an
> optional port just for your code additions.
Concur - there are places where people rely that it has the port 
mandatory. Changing it to optional will break too much unrelated code.

--
Anton R. Ivanov

Cambridge Greys Limited, England and Wales company No 10273661
http://www.cambridgegreys.com/