Re: [Qemu-devel] [PATCH v1 3/6] target/s390x: implement spm (SET PROGRAM MASK)

[Richard Henderson]

On 07/21/2017 05:56 AM, David Hildenbrand wrote:
> +    tcg_gen_extrl_i64_i32(cc, o->in1);
> +    tcg_gen_shri_i32(cc, cc, 28);
> +    tcg_gen_andi_i32(cc, cc, 0x3ul);
> +    tcg_gen_mov_i32(cc_op, cc);
> +    tcg_temp_free_i32(cc);
> +    set_cc_static(s);

 tcg_gen_extrl_i64_i32(cc_op, o->in1);
 tcg_gen_extract_i32(cc_op, cc_op, 28, 2);


Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~