Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

[Ladi Prosek]

On Fri, Jul 21, 2017 at 12:12 PM, Igor Mammedov <address@hidden> wrote:
> On Fri, 21 Jul 2017 11:54:20 +0200
> Ladi Prosek <address@hidden> wrote:
>
>> On Fri, Jul 21, 2017 at 11:32 AM, Igor Mammedov <address@hidden> wrote:
>> > w2k used to boot on QEMU until we bumped revision of FADT to rev3
>> > (commit 77af8a2b hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to 
>> > improve guest OS support.)
>> >
>> > Considering that w2k is ancient and long time EOLed, leave default
>> > rev3 but make pc-i440fx-2.9 and older machine types to force rev1
>> > so old setups won't break (w2k could boot).
>> >
>> > Signed-off-by: Igor Mammedov <address@hidden>
>> > ---
>> > CC: Programmingkid <address@hidden>
>> > CC: Phil Dennis-Jordan <address@hidden>
>> > CC: "Michael S. Tsirkin" <address@hidden>
>> >
>> > Only compile test since I don't have w2k to test with
>>
>> Confirming that Windows 2000 boots with this patch and -machine 
>> pc-i440fx-2.9.
> Ladi,
>
> Could you to try find out reason why w2k doesn't boot?

The FADT table must be 134 bytes or less. The revision number does not
matter and neither does the checksum.

This is experimental data, I haven't been able to find the offending code.

>>
>> Tested-by: Ladi Prosek <address@hidden>
>