[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10] util: Introduce include/qemu/cpuid.h
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10] util: Introduce include/qemu/cpuid.h |
Date: |
Mon, 24 Jul 2017 11:40:43 +0100 |
On 19 July 2017 at 05:40, Richard Henderson <address@hidden> wrote:
> Clang 3.9 passes the CONFIG_AVX2_OPT configure test. However, the
> supplied <cpuid.h> does not contain the bit_AVX2 define that we use
> when detecting whether the routine can be enabled.
>
> Introduce a qemu-specific header that uses the compiler's definition
> of __cpuid et al, but supplies any missing bit_* definitions needed.
> This avoids introducing any extra ifdefs to util/bufferiszero.c, and
> allows quite a few to be removed from tcg/i386/tcg-target.inc.c.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>
> Peter, this is the clang 3.9 problem I mentioned the other day,
> when attempting to reproduce the other clang 3.8 problem.
>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM