Re: [Qemu-devel] [PATCH 0/2] improve tracing

[Stefan Hajnoczi]

On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Current trace system have a drawback: parameters of trace functions
> are calculated even if corresponding tracepoint is disabled. Also, it
> looks like trace function are not actually inlined by compiler (at
> least for me).
> 
> Here is a fix proposal: move from function call to macros. Patch 02
> is an example, of how to reduce extra calculations with help of
> patch 01.
> 
> Vladimir Sementsov-Ogievskiy (2):
>   trace: do not calculate arguments for disabled trace-points
>   monitor: improve tracing in handle_qmp_command

Please use the TRACE_FOO_ENABLED macro instead of putting computation
inside the trace event arguments.  This makes the code cleaner and
easier to read.

signature.asc
Description: PGP signature