[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] monitor: improve tracing in handle_qmp_comm
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] monitor: improve tracing in handle_qmp_command |
|
Date: |
Mon, 24 Jul 2017 12:39:52 +0100 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Jul 21, 2017 at 05:31:49PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Calculate req_json only if trace_handle_qmp_command enabled.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Is there a real-world performance issue?
(I'm not against this change but it's important to understand the
rationale for performance optimizations.)
The monitor is a control channel. Anything using it at high frequency
with low latency expectations will be disappointed. We should look at
such cases and decide whether the monitor really is the appropriate
interface for them.
Stefan
signature.asc
Description: PGP signature