[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] char-fd: remove useless chr pointer
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] char-fd: remove useless chr pointer |
Date: |
Mon, 24 Jul 2017 19:10:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 20/07/2017 12:00, Marc-André Lureau wrote:
> Apparently unused since it was introduced in commit
> a29753f8aa79a34a324afebe340182a51a5aef11. Now, it can be trivially
> accessed by CHARDEV() of self.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> include/chardev/char-fd.h | 2 +-
> chardev/char-fd.c | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/chardev/char-fd.h b/include/chardev/char-fd.h
> index 55ae5b47b0..e7c2b176f9 100644
> --- a/include/chardev/char-fd.h
> +++ b/include/chardev/char-fd.h
> @@ -29,7 +29,7 @@
>
> typedef struct FDChardev {
> Chardev parent;
> - Chardev *chr;
> +
> QIOChannel *ioc_in, *ioc_out;
> int max_size;
> } FDChardev;
> diff --git a/chardev/char-fd.c b/chardev/char-fd.c
> index 1584a3de20..6a62a545f2 100644
> --- a/chardev/char-fd.c
> +++ b/chardev/char-fd.c
> @@ -141,7 +141,6 @@ void qemu_chr_open_fd(Chardev *chr,
> qio_channel_set_name(QIO_CHANNEL(s->ioc_out), name);
> g_free(name);
> qemu_set_nonblock(fd_out);
> - s->chr = chr;
> }
>
> static void char_fd_class_init(ObjectClass *oc, void *data)
>
Queued for 2.10 as it's a trivial dead code removal.
Paolo