Re: [Qemu-devel] [PATCH v1 0/6] target/s390x: tcg improvments + MSA functions

[David Hildenbrand]

On 24.07.2017 05:16, Richard Henderson wrote:
> On 07/21/2017 05:56 AM, David Hildenbrand wrote:
>> 1. smaller pgm irq instruction length fixes
> 
> I think maybe we should add insn length data to the unwind data, so that we 
> can 
> have env->int_pgm_ilen set to the right value whenever cpu_restore_state is 
> called.
> 
> 
> r~
> 

You mean, passing a third argument to tcg_gen_insn_start():
        tcg_gen_insn_start(dc.pc, dc.cc_op, dc.ilen);

by setting TARGET_INSN_START_EXTRA_WORDS=2 ?

Then we would have to do instruction length detection before
tcg_gen_insn_start() and therefore before translate_one().


-- 

Thanks,

David