Re: [Qemu-devel] [PATCH for 2.10 21/35] arm/sysbus-fdt: fix null pointer dereference

[Philippe Mathieu-Daudé]

On 07/24/2017 06:09 PM, Peter Maydell wrote:
> On 24 July 2017 at 19:27, Philippe Mathieu-Daudé <address@hidden> wrote:
> > Use error_report() + exit() instead of error_setg(&error_fatal).
> >
> > hw/arm/sysbus-fdt.c:322:9: warning: Array access (from variable 'node_path') 
> > results in a null pointer dereference
> >      if (node_path[1]) {
> >          ^~~~~~~~~~~~
>
> I don't understand what this warning is trying to say.
> We can't get to this point with a NULL node_path,
> because of the previous conditional, which is using
> error_setg(&error_fatal).

Ok I see, Clang is unaware than error_setg(&error_fatal) is a noreturn.

Patch dropped.

Thanks,

Phil.