Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model

[David Gibson]

On Tue, Jul 25, 2017 at 11:26:13AM +1000, Alexey Kardashevskiy wrote:
> On 24/07/17 23:00, Cédric Le Goater wrote:
> >>> +#include "qemu/osdep.h"
> >>> +#include "qemu/log.h"
> >>> +#include "qapi/error.h"
> >>> +#include "target/ppc/cpu.h"
> >>> +#include "sysemu/cpus.h"
> >>> +#include "sysemu/dma.h"
> >>> +#include "monitor/monitor.h"
> >>> +#include "hw/ppc/xive.h"
> >>> +
> >>> +#include "xive-internal.h"
> >>> +
> >>> +/*
> >>> + * Main XIVE object
> >>
> >> As with XICs, does it really make sense for there to be a "main" XIVE
> >> object, or should be an interface attached to the machine?
> > 
> > yes. There are internal tables which are very specific to the controller 
> > and I don't think they belong to the machine.
> 
> These tables belong to a CPU chip (die?) and we do not emulate these now
> (machines and cores are the closest) and since we do not want (do we?) to
> treat a core as a chip, the machine is the most obvious owner for these 
> tables.

No, I think it's reasonable for them to be owned by a XIVE object
under the machine.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature