qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] migration: optimize the downtime


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] migration: optimize the downtime
Date: Tue, 25 Jul 2017 10:18:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 25/07/2017 09:29, Jay Zhou wrote:
>>
>>
>> Maybe memory_global_dirty_log_stop can delay itself to the next vm_start
>> if it's called while runstate_running() returns false (which should be
>> always the case)?
> 
> It is logical, but then we need to put some migration related codes into
> the file of cpus.c(in my patch, I put some codes into the file of qmp.c),
> is there any elegant way to reduce the coupling?

See below:

>> It could even be entirely enclosed within memory.c if you do it with a
>> VMChangeStateHandler. 

If memory_global_dirty_log_stop runs with !runstate_running(), instead
of doing the memory transaction you set a VMChangeStateHandler and
return immediately.

The VMChangeStateHandler then does the actual work just before the VM
starts running.

memory_global_dirty_log_start also needs to delete the
VMChangeStateHandler if it is present.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]