Re: [Qemu-devel] [PATCH 7/9] tests: Clean up wait for event

[Stefan Hajnoczi]

On Fri, Jul 21, 2017 at 03:53:24PM +0200, Markus Armbruster wrote:
> We still use hacks like qmp("") to wait for an event, even though we
> have qmp_eventwait() since commit 8fe941f, and qmp_eventwait_ref()
> since commit 7ffe312.  Both commits neglected to convert all the
> existing hacks.  Make up what they missed.
> 
> Bonus: gets rid of empty format strings.  A step towards compile-time
> format string checking without triggering -Wformat-zero-length.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  tests/boot-order-test.c   |  2 +-
>  tests/libqos/pci-pc.c     |  6 +-----
>  tests/tco-test.c          |  3 +--
>  tests/usb-hcd-uhci-test.c |  6 +-----
>  tests/usb-hcd-xhci-test.c | 12 ++----------
>  tests/wdt_ib700-test.c    | 35 ++++++++++-------------------------
>  6 files changed, 16 insertions(+), 48 deletions(-)

Nice!

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature