[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode'
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode' |
Date: |
Tue, 25 Jul 2017 19:10:10 +0200 |
The 'returncode' Popen attribute is not guaranteed to be updated. It
actually depends on a call to either poll(), wait() or communicate().
On the other hand, poll() will "Check if child process has terminated.
Set and return returncode attribute."
Let's use the poll() to check whether the process is running and also
to get the updated process exit code, if any.
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 59ed5270f8..f37e2fe58e 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -86,12 +86,12 @@ class QEMUMachine(object):
raise
def is_running(self):
- return self._popen and (self._popen.returncode is None)
+ return self._popen and (self._popen.poll() is None)
def exitcode(self):
if self._popen is None:
return None
- return self._popen.returncode
+ return self._popen.poll()
def get_pid(self):
if not self.is_running():
--
2.13.3
- [Qemu-devel] [PATCH v5 0/6] scripts/qemu.py fixes and cleanups, Amador Pahim, 2017/07/25
- [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public, Amador Pahim, 2017/07/25
- [Qemu-devel] [PATCH v5 5/6] qemu.py: make sure shutdown() is called before launching again, Amador Pahim, 2017/07/25
- [Qemu-devel] [PATCH v5 6/6] qemu.py: include qemu command line and output on launch error, Amador Pahim, 2017/07/25
- [Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode',
Amador Pahim <=
- [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code, Amador Pahim, 2017/07/25
- Re: [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code, Stefan Hajnoczi, 2017/07/27
- [Qemu-devel] [PATCH v5 4/6] qemu.py: cleanup launch(), Amador Pahim, 2017/07/25