Re: [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code

[Cleber Rosa]

On 07/25/2017 01:10 PM, Amador Pahim wrote:
> The message contains the self._args, which has only part of the
> options used in the qemu command line and is not representative
> enough to figure out what happened to the process.
> 
> This patch drops the self._args part of the message.
> 

Since this patch comes after the proposed "self._args" rename, it should
use the new name.

> Signed-off-by: Amador Pahim <address@hidden>
> ---
>  scripts/qemu.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index f37e2fe58e..56142ed59b 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -154,7 +154,8 @@ class QEMUMachine(object):
>  
>              exitcode = self._popen.wait()
>              if exitcode < 0:
> -                sys.stderr.write('qemu received signal %i: %s\n' % 
> (-exitcode, ' '.join(self.args)))
> +                sys.stderr.write('qemu received signal %i\n' % -exitcode)
> +
>              self._load_io_log()
>              self._post_shutdown()
>  
> 

-- 
Cleber Rosa
[ Sr Software Engineer - Virtualization Team - Red Hat ]
[ Avocado Test Framework - avocado-framework.github.io ]
[  7ABB 96EB 8B46 B94D 5E0F  E9BB 657E 8D33 A5F2 09F3  ]

signature.asc
Description: OpenPGP digital signature