Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

[Philippe Mathieu-Daudé]

Hi Michael,

On 07/25/2017 08:03 PM, Michael Roth wrote:
> Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30)
> > Reported-by: Sameeh Jubran <address@hidden>
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> > original report from Sameeh Jubran:
> > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg00906.html
>
> AFAICT the issue discussed in the context of that patch is simply that
> the qemu-ga.exe file isn't deleted as part of `make clean`, which does
> seem to be an issue.
>
> But qemu.ga.exe is created just fine as part of `make qemu-ga`, at least
> as of:
>
>    fafcaf1d build: qemu-ga: add 'qemu-ga' build target for w32

Yes, on w32 if "make ASDF" invokes the linker, it will create ASDF.exe.

> The 'qemu-ga' target is actually an intermediate target which, on w32,
> creates the MSI package (if configured) as well as qemu-ga.exe.
>
> >   Makefile  | 2 +-
> >   configure | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index ef721480eb..5f18243d05 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -490,7 +490,7 @@ clean:
> >          rm -f qemu-options.def
> >          rm -f *.msi
> >          find . \( -name '*.so' -o -name '*.dll' -o -name '*.mo' -o -name 
> > '*.[oda]' \) -type f -exec rm {} +
> > -       rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS cscope.* 
> > *.pod *~ */*~
> > +       rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) TAGS cscope.* *.pod *~ 
> > */*~

On win32, this patch add qemu-ga.exe instead of qemu-ga in $TOOLS, so 
when the 'clean' target is executed it removes qemu-ga.exe (Sameeh 
Jubran report). Before this patch the $TOOLS looks like:
"qemu-img.exe qemu-io.exe qemu-nbd.exe ivshmem-client.exe 
ivshmem-server.exe qemu-ga fsdev/virtfs-proxy-helper.exe"
The only executables which doesn't match %.exe is qemu-ga, so the 
'clean' target remove all .exe _but_ qemu-ga.exe.

Now if by "this is not an issue" you mean it is not a bug, I agree this 
can wait 2.11.

Regards,

Phil.

> >          rm -f fsdev/*.pod
> >          rm -f qemu-img-cmds.h
> >          rm -f ui/shader/*-vert.h ui/shader/*-frag.h
> > diff --git a/configure b/configure
> > index 48d4d7a2a7..f8b1d014d7 100755
> > --- a/configure
> > +++ b/configure
> > @@ -5073,7 +5073,7 @@ fi
> >
> >   if [ "$guest_agent" != "no" ]; then
> >     if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" -o "$mingw32" = 
> > "yes" ] ; then
> > -      tools="qemu-ga $tools"
> > +      tools="qemu-ga\$(EXESUF) $tools"
> >         guest_agent=yes
> >     elif [ "$guest_agent" != yes ]; then
> >         guest_agent=no
> > --
> > 2.13.3