Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

[Peter Maydell]

On 26 July 2017 at 06:15, Programmingkid <address@hidden> wrote:
>
>> On Jul 26, 2017, at 12:13 AM, Philippe Mathieu-Daudé <address@hidden> wrote:
>>
>> Hi John,
>>
>> On 07/25/2017 07:55 PM, Programmingkid wrote:
>>> While compiling the mips64el-softmmu target I encountered these errors:
>>>   CC      hw/display/g364fb.o
>>> hw/core/loader-fit.c:105:41: error: expected expression
>>>         *addr = fdt32_to_cpu(*(fdt32_t *)prop);
>>>                                         ^
>>> hw/core/loader-fit.c:105:32: error: use of undeclared identifier 'fdt32_t'
>>
>> It seems you are missing the libfdt headers, so indeed you found bug.

Configure requires libfdt to exist to enable mips64el-softmmu,
so something is going wrong with our configure test compared
to how QEMU itself is being built.

> That appears to help make things move past the loader-fit.c file. Here are 
> the new errors:
>
>   CC      hw/core/loader-fit.o
>   CC      hw/dma/rc4030.o
>   CC      hw/ide/via.o
> hw/core/loader-fit.c:105:41: error: expected expression
>         *addr = fdt32_to_cpu(*(fdt32_t *)prop);
>                                         ^

...this is still failing on loader-fit.c in the same way.

>> And also the ./configure output, I'm interested by:
>>
>> "fdt support       no”
>
> Actually it was "fdt support       yes”.

Configure thinks the fdt headers are available...

> ./configure --target-list=mips64el-softmmu
> Install prefix    /usr/local
> BIOS directory    /usr/local/share/qemu
> binary directory  /usr/local/bin
> library directory /usr/local/lib
> module directory  /usr/local/lib/qemu
> libexec directory /usr/local/libexec
> include directory /usr/local/include
> config directory  /usr/local/etc
> local state directory   /usr/local/var
> Manual directory  /usr/local/share/man
> ELF interp prefix /usr/gnemul/qemu-%M
> Source path       /Users/john/Documents/Development/Projects/Qemu/qemu-git
> C compiler        cc
> Host C compiler   cc
> C++ compiler      c++
> Objective-C compiler clang
> ARFLAGS           rv
> CFLAGS            -O2 -g
> QEMU_CFLAGS       -I/usr/local/Cellar/pixman/0.34.0/include/pixman-1 
> -I$(SRC_PATH)/dtc/libfdt -D_REENTRANT -I/usr/local/Cellar/glib/2.46.2/include

...and it's put our local copy of libfdt on the include path.

The fdt32_t type that the compiler is complaining
about ought to be defined in the header in
dtc/libfdt/libfdt_env.h.

I wonder if you have an old copy of that submodule;
if so then "git submodule update" ought to fix it.

thanks
-- PMM