Re: [Qemu-devel] [PULL v2 1/8] target/s390x: Implement CSST

[Paolo Bonzini]

On 17/07/2017 23:24, Richard Henderson wrote:
> +        case 4:
> +            if (parallel_cpus) {
> +#ifdef CONFIG_ATOMIC128
> +                TCGMemOpIdx oi = make_memop_idx(MO_TEQ | MO_ALIGN_16, 
> mem_idx);
> +                Int128 sv = int128_make128(svl, svh);
> +                helper_atomic_sto_be_mmu(env, a2, sv, oi, ra);
> +#else
> +                /* Note that we asserted !parallel_cpus above.  */
> +                g_assert_not_reached();
> +#endif
> +            } else {
> +                cpu_stq_data_ra(env, a2 + 0, svh, ra);
> +                cpu_stq_data_ra(env, a2 + 8, svl, ra);
> +            }
> +        default:
> +            g_assert_not_reached();

Coverity complains about a missing "break".

Paolo