qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
Date: Wed, 26 Jul 2017 08:06:15 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/26/2017 07:49 AM, Gerd Hoffmann wrote:
>   Hi,
> 
>> error message).  I suspect this is caused by your use of '@ac_*'
>> instead
>> of spelling out all the ac_ members added in qapi-schema.json in 4/5
>> -
> 
> Hmm, adding them all will be a pretty long list, and it will probably
> become alot longer when we add more missing keys in 2.11 ...
> 
> Should this maybe summarized along the lines of "# multimedia keys
> added in 2.10"?

I'm not sure what the doc-generator will insist on, but avoiding the
@name form may be sufficient.  I agree that for this particular enum,
the lists get quite long, so abbreviating may make sense, but at the
same time, being precise may be more useful for someone trying to grep
documentation.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]