[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 13/14] qmp.py: Avoid overriding a builtin object
From: |
Lukáš Doktor |
Subject: |
[Qemu-devel] [PATCH v3 13/14] qmp.py: Avoid overriding a builtin object |
Date: |
Wed, 26 Jul 2017 16:35:42 +0200 |
The "id" is a builtin method to get object's identity and should not be
overridden. This might bring some issues in case someone was directly
calling "cmd(..., id=id)" but I haven't found such usage on brief search
for "cmd\(.*id=".
Signed-off-by: Lukáš Doktor <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
---
scripts/qmp/qmp.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py
index f2f5a9b..ef12e8a 100644
--- a/scripts/qmp/qmp.py
+++ b/scripts/qmp/qmp.py
@@ -177,19 +177,19 @@ class QEMUMonitorProtocol(object):
print >>sys.stderr, "QMP:<<< %s" % resp
return resp
- def cmd(self, name, args=None, id=None):
+ def cmd(self, name, args=None, cmd_id=None):
"""
Build a QMP command and send it to the QMP Monitor.
@param name: command name (string)
@param args: command arguments (dict)
- @param id: command id (dict, list, string or int)
+ @param cmd_id: command id (dict, list, string or int)
"""
qmp_cmd = {'execute': name}
if args:
qmp_cmd['arguments'] = args
- if id:
- qmp_cmd['id'] = id
+ if cmd_id:
+ qmp_cmd['id'] = cmd_id
return self.cmd_obj(qmp_cmd)
def command(self, cmd, **kwds):
--
2.9.4
- [Qemu-devel] [PATCH v3 03/14] qemu-iotests: Fix reference output for 186, (continued)
- [Qemu-devel] [PATCH v3 03/14] qemu-iotests: Fix reference output for 186, Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 04/14] Update version for v2.10.0-rc0 release, Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 06/14] qemu|qtest: Avoid dangerous arguments, Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 07/14] qemu.py: Use iteritems rather than keys(), Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 05/14] qemu.py: Pylint/style fixes, Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 08/14] qemu.py: Simplify QMP key-conversion, Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 11/14] qmp.py: Use object-based class for QEMUMonitorProtocol, Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 09/14] qemu.py: Use custom exceptions rather than Exception, Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 10/14] qmp.py: Couple of pylint/style fixes, Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 12/14] qmp.py: Avoid "has_key" usage, Lukáš Doktor, 2017/07/26
- [Qemu-devel] [PATCH v3 13/14] qmp.py: Avoid overriding a builtin object,
Lukáš Doktor <=
- [Qemu-devel] [PATCH v3 14/14] qtest.py: Few pylint/style fixes, Lukáš Doktor, 2017/07/26
- Re: [Qemu-devel] [PATCH v3 00/14] qemu.py: Pylint/style fixes, Lukáš Doktor, 2017/07/26