[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/5] Convert remaining error_report() to warn
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v1 2/5] Convert remaining error_report() to warn_report() |
Date: |
Thu, 27 Jul 2017 10:07:19 +0200 |
On Wed, 26 Jul 2017 09:07:52 -0700
Alistair Francis <address@hidden> wrote:
> In a previous patch (3dc6f8693694a649a9c83f1e2746565b47683923) we
> converted uses of error_report("warning:"... to use warn_report()
> instead. This was to help standardise on a single method of printing
> warnings to the user.
>
> There appears to have been some cases that slipped through in patch sets
> applied around the same time, this patch catches the few remaining
> cases.
>
> All of the warnings were changed using this command:
> find ./* -type f -exec sed -i \
> 's|error_report(".*warning[,:] |warn_report("|Ig' {} +
>
> Indentation fixed up manually afterwards.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> Cc: Christian Borntraeger <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
Hm, the automatic cc:ing does not seem to have worked.
> ---
>
> block/qcow2.c | 10 +++++-----
> target/s390x/kvm.c | 4 ++--
> trace/control.c | 4 ++--
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> index c4c5791d27..1084923adb 100644
> --- a/target/s390x/kvm.c
> +++ b/target/s390x/kvm.c
> @@ -222,8 +222,8 @@ static void kvm_s390_enable_cmma(void)
> };
>
> if (mem_path) {
> - error_report("Warning: CMM will not be enabled because it is not "
> - "compatible to hugetlbfs.");
> + warn_report("CMM will not be enabled because it is not "
> + "compatible to hugetlbfs.");
> return;
> }
> rc = kvm_vm_ioctl(kvm_state, KVM_SET_DEVICE_ATTR, &attr);
s390x part:
Acked-by: Cornelia Huck <address@hidden>
[Qemu-devel] [PATCH v1 4/5] Convert multi-line fprintf() to warn_report(), Alistair Francis, 2017/07/26