[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/8] usb-ccid: Add support to dump all USB pa
|
From: |
Stefan Fritsch |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/8] usb-ccid: Add support to dump all USB packets |
|
Date: |
Thu, 27 Jul 2017 10:55:09 +0200 (CEST) |
|
User-agent: |
Alpine 2.11 (DEB 23 2013-08-11) |
On Fri, 21 Jul 2017, Gerd Hoffmann wrote:
> > index bef1f03c42..624dc2c447 100644
> > --- a/hw/usb/dev-smartcard-reader.c
> > +++ b/hw/usb/dev-smartcard-reader.c
> > @@ -54,9 +54,25 @@ do { \
> > #define D_INFO 2
> > #define D_MORE_INFO 3
> > #define D_VERBOSE 4
> > +#define D_TRACE 5
> > +#define D_REMOTEIO 10
>
> Considered converting all DPRINTFs into tracepoints instead?
>
> Then you can turn then on/off individually as needed.
I want to have D_WARN enabled by default, so those cannot be trace points.
And there are some that use qemu_hexdump which cannot be converted,
either. I don't think it makes sense to convert the rest.
Cheers,
Stefan