[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Add more function keys to QEMU
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Add more function keys to QEMU |
Date: |
Thu, 27 Jul 2017 09:55:09 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/27/2017 09:51 AM, Programmingkid wrote:
You forgot in-reply-to: and references: headers, meaning this was not
threaded with your 0/2 patch.
> There are now keyboards that have 19 function keys. This patch extends QEMU
> so these function keys can be used.
>
> Signed-off-by: John Arbuckle <address@hidden>
> ---
> qapi-schema.json | 6 +++++-
> ui/input-keymap.c | 4 ++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
Conflicts with Gerd's pending UI pull; so you'll need to rebase.
Furthermore, while Gerd added keys after softfreeze (necessary to fix a
regression), your additions seem to be a new feature rather than a bug
fix, and may therefore be more appropriate for 2.11.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature