Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

[Eric Blake]

On 07/28/2017 07:19 AM, Peter Maydell wrote:
> On 28 July 2017 at 13:08, Eric Blake <address@hidden> wrote:
>> On 07/28/2017 04:04 AM, Peter Maydell wrote:
>>> On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy
>>> <address@hidden> wrote:
>>>> To make logs more readable prefix all hex values with '0x' mark.
>>>> This is needed for consistency too, as a lot of hex values are already
>>>> prefixed with '0x'. Also, bring all hex outputs to the common form -
>>>> use '%#', not '0x%'.
>>>>
>>>> This patch is done by two commands:
>>>> find . -name trace-events | \
>>>>  xargs sed -i 's/%\([-+ 
>>>> *.0-9]*\([hljztL]\|ll\|hh\)\?\(x\|X\|"\s*PRIx\)\)/%#\1/g'
>>
>> Why PRIx32 but not PRIX32?
> 
> As it happens none of our trace-events files use PRIX...

True for now, but if we're going to add a checkpatch.pl rule to enforce
things, then the regex should cover it for future additions.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature