[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI |
|
Date: |
Fri, 28 Jul 2017 13:07:43 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/28/2017 12:17 PM, Dr. David Alan Gilbert wrote:
> * Markus Armbruster (address@hidden) wrote:
>> COLOMode is defined in the QAPI schema, but not used there. Of the
>> stuff QAPI generates for it only the typedef is actually used. Use of
>> QAPI is pointless and only complicates things, so don't.
>
> Hmm, in one of the old COLO worlds I have, there's code to emit an event
> on exiting from COLO and that event includes the mode it was in.
>
> If the intent is to bring that or similar back then it would be worth
> keeping.
We can always revert the removal once there is a user.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature