[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAIN
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS |
Date: |
Fri, 28 Jul 2017 14:52:48 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/28/2017 12:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/check_maintainer.sh | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100755 scripts/check_maintainer.sh
>
> +echo "Incorrect MAINTAINERS paths:" 1>&2
> +egrep ^F: MAINTAINERS | cut -d\ -f2 | while read p; do
> + ls -ld $p 1>/dev/null
> +done
Ah, you uses this in a cover letter of your other series, where I
responded without thinking it was going into git. But now that I see we
are trying to commit it, I really think that one 'ls -l >/dev/null' per
filename is inefficient; this should be
egrep ^F: MAINTAINERS | cut -d\ -f2 | xargs ls -d >/dev/null
if we really like the side effect of ls writing to stdout as the way to
identify globs that no longer map anywhere, or even something like:
for glob in $(egrep ... | cut ...); do
set - $glob
if test -n "$2" && ! test -e "$1"; then
echo "glob $glob no longer resolves" 2>&1
fi
done
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 40/47] MAINTAINERS: add missing entry for AIO, (continued)
- [Qemu-devel] [RFC PATCH 41/47] MAINTAINERS: add missing I2C entries, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 43/47] MAINTAINERS: add missing TPM entries, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 42/47] MAINTAINERS: add missing Bluetooth entries, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 44/47] MAINTAINERS: add missing entry for tilegx, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 45/47] MAINTAINERS: add missing entries for loader, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts, Philippe Mathieu-Daudé, 2017/07/28
- Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts, Eric Blake, 2017/07/28