[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_M
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX |
Date: |
Sat, 29 Jul 2017 20:34:26 +0100 |
On 29 July 2017 at 14:50, Patrick Steinhardt <address@hidden> wrote:
> On Fri, Jul 28, 2017 at 02:20:49PM -0300, Philippe Mathieu-Daudé wrote:
>> This is likely to break on BSD, but now than patchew has a NetBSD job
>> you can trigger a build RESENDing this patch.
> Thanks for the feedback! Is this really relevant in this context,
> though? Both 9p-local.c and 9p-handle.c already include linux
> headers, especially <linux/fs.h> is included without any ifdef
> around. As such, I simply assumed that this code is being built
> on Linux systems, only.
Yes; hw/Makefile.objs only includes the 9pfs directory
if CONFIG_VIRTFS is defined, and configure only sets that
on Linux hosts which have libpcap and libattr available.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Alistair Francis, 2017/07/28
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Philippe Mathieu-Daudé, 2017/07/28
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Patrick Steinhardt, 2017/07/29
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Kamil Rytarowski, 2017/07/30
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Peter Maydell, 2017/07/30
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Kamil Rytarowski, 2017/07/30
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Fam Zheng, 2017/07/31
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Peter Maydell, 2017/07/31
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Daniel P. Berrange, 2017/07/31
- Re: [Qemu-devel] [PATCH] 9pfs: include <linux/limits.h> for XATTR_SIZE_MAX, Kamil Rytarowski, 2017/07/31