[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before firs
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before first launch() |
Date: |
Mon, 31 Jul 2017 10:51:05 +0200 |
is_running() returns None when called before the first time we
call launch():
>>> import qemu
>>> vm = qemu.QEMUMachine('qemu-system-x86_64')
>>> vm.is_running()
>>>
It should retunt False instead. This patch fixes that.
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 2f1984c93c..77565eb092 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -86,7 +86,7 @@ class QEMUMachine(object):
raise
def is_running(self):
- return self._popen and (self._popen.poll() is None)
+ return self._popen is not None and (self._popen.poll() is None)
def exitcode(self):
if self._popen is None:
--
2.13.3
- [Qemu-devel] [PATCH v6 0/7] scripts/qemu.py fixes and cleanups, Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before first launch(),
Amador Pahim <=
- [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system, Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 1/7] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 4/7] qemu.py: improve message on negative exit code, Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 5/7] qemu.py: use os.path.null instead of /dev/null, Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 6/7] qemu.py: cleanup and improve launch()/shutdown(), Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 7/7] qemu.py: include debug information on launch error, Amador Pahim, 2017/07/31