[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState |
Date: |
Mon, 31 Jul 2017 17:39:29 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
* Peter Xu (address@hidden) wrote:
> Comments for "migration_dirty_pages" and "bitmap_mutex" are switched.
> Fix it.
>
> Signed-off-by: Peter Xu <address@hidden>
Split this out, it can go in a trivial patch probably sooner.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/ram.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index c93973c..c12358d 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -222,9 +222,9 @@ struct RAMState {
> uint64_t iterations_prev;
> /* Iterations since start */
> uint64_t iterations;
> - /* protects modification of the bitmap */
> - uint64_t migration_dirty_pages;
> /* number of dirty bits in the bitmap */
> + uint64_t migration_dirty_pages;
> + /* protects modification of the bitmap */
> QemuMutex bitmap_mutex;
> /* The RAMBlock used in the last src_page_requests */
> RAMBlock *last_req_rb;
> --
> 2.7.4
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [RFC 00/29] Migration: postcopy failure recovery, Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 01/29] migration: fix incorrect postcopy recved_bitmap, Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState, Peter Xu, 2017/07/28
- Re: [Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState,
Dr. David Alan Gilbert <=
- [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling, Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert(), Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 05/29] bitmap: introduce bitmap_count_one(), Peter Xu, 2017/07/28
- [Qemu-devel] [RFC 06/29] migration: dump str in migrate_set_state trace, Peter Xu, 2017/07/28