|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [Qemu-devel] [PATCH v3 2/4] trace-events: fix code style: %# -> 0x% |
Date: | Mon, 31 Jul 2017 19:40:44 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
31.07.2017 19:15, Eric Blake wrote:
On 07/31/2017 11:01 AM, Vladimir Sementsov-Ogievskiy wrote:In trace format '#' flag of printf is forbidden. Fix it to '0x%'. This patch is created by the following: check that we have a problemfind . -name trace-events | xargs grep '%#' | wc -l56 check that there are no cases with additional printf flags before '#'find . -name trace-events | xargs grep '%[-+ 0'I]+#' | wc -lThat's not the actual command you used; maintainer can fix the typo by using "%[-+ 0'I]+#" instead.
Aha yes, you are right. I've checked out the previous commit, checked it by a command with "%[-+ 0'I]+#"
and then separately fixed the commit message, forgotten to s/'/"/. Yes, if a new version will not be required, fix this inflight please.
0 check that there are no wrong usage of '#' and '0x' togetherfind . -name trace-events | xargs grep '0x%#' | wc -l0 fix the problemfind . -name trace-events | xargs sed -i 's/%#/0x%/g'Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden> Reviewed-by: Stefan Hajnoczi <address@hidden> Reviewed-by: Eric Blake <address@hidden> ---
-- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |