Re: [Qemu-devel] [RFC 01/29] migration: fix incorrect postcopy recved_bitmap

[Alexey Perevalov]

On 08/01/2017 09:02 AM, Peter Xu wrote:
> On Tue, Aug 01, 2017 at 08:48:18AM +0300, Alexey Perevalov wrote:
> > On 08/01/2017 05:11 AM, Peter Xu wrote:
> > > On Mon, Jul 31, 2017 at 05:34:14PM +0100, Dr. David Alan Gilbert wrote:
> > > > * Peter Xu (address@hidden) wrote:
> > > > > The bitmap setup during postcopy is incorrectly when the pgaes are huge
> > > > > pages. Fix it.
> > > > >
> > > > > Signed-off-by: Peter Xu <address@hidden>
> > > > > ---
> > > > >   migration/postcopy-ram.c | 2 +-
> > > > >   migration/ram.c          | 8 ++++++++
> > > > >   migration/ram.h          | 2 ++
> > > > >   3 files changed, 11 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> > > > > index 276ce12..952b73a 100644
> > > > > --- a/migration/postcopy-ram.c
> > > > > +++ b/migration/postcopy-ram.c
> > > > > @@ -578,7 +578,7 @@ static int qemu_ufd_copy_ioctl(int userfault_fd, void 
> > > > > *host_addr,
> > > > >           ret = ioctl(userfault_fd, UFFDIO_ZEROPAGE, &zero_struct);
> > > > >       }
> > > > >       if (!ret) {
> > > > > -        ramblock_recv_bitmap_set(host_addr, rb);
> > > > > +        ramblock_recv_bitmap_set_range(rb, host_addr, pagesize / 
> > > > > getpagesize());
> > > > isn't that   pagesize / qemu_target_page_size() ?
> > > >
> > > > Other than that it looks OK.
> > > Yes, I should have fixed this before.
> > >
> > > I guess Alexey will handle this change (along with the copied bitmap
> > > series)?  Anyway, I'll fix it as well in my series, until Alexey post
> > > the new version that I can rebase to.  Thanks,
> > I'll squash it, and I'll resend it today.
> > Are you agree to add
> >
> > Signed-off-by: Peter Xu <address@hidden>
> >
> > to my patch?
> Firstly, if you are squashing the patch, fixing the issue that Dave
> has pointed out, please feel free to add my R-b on the patch.
Of course I'll take into account David's suggestion.
> I don't know whether it would be suitable to add my S-o-b here - since
> most of the patch content is written by you, not me. But I'm totally
> fine if you want to include that (btw, thanks for the offer :).
>
> So either one R-b or S-o-b is okay to me.  Thanks,

--
Best regards,
Alexey Perevalov