qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.10 3/3] target/mips: Fix RDHWR CC with ico


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH for-2.10 3/3] target/mips: Fix RDHWR CC with icount
Date: Wed, 2 Aug 2017 08:01:34 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 08/02/2017 02:59 AM, James Hogan wrote:
RDHWR CC reads the CPU timer like MFC0 CP0_Count, so with icount enabled
it must set can_do_io while it calls the helper to avoid the "Bad icount
read" error. It should also break out of the translation loop to ensure
that timer interrupts are immediately handled.

Fixes: 2e70f6efa8b9 ("Add instruction counter.")
Signed-off-by: James Hogan<address@hidden>
Cc: Aurelien Jarno<address@hidden>
Cc: Yongbok Kim<address@hidden>
---
I've based this on MFC0 Count, but this instruction is also available to
usermode (e.g. CONFIG_USER_ONLY), which I presume is still fine.
---
  target/mips/translate.c | 11 +++++++++++
  1 file changed, 11 insertions(+), 0 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]