Re: [Qemu-devel] [PATCH 1/6] tests/tcg/test_path.c: include utils/bufferiszero.c

[Philippe Mathieu-Daudé]

Hi Cleber,

On 08/02/2017 05:15 PM, Cleber Rosa wrote:
> Which contains one specific function used by iov.c.
>
> Without this, "make -C tests/tcg test_path" (and consequently
> "make -C tests/tcg" or simply "make test") fails quite early.
>
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
>   tests/tcg/test_path.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/tcg/test_path.c b/tests/tcg/test_path.c
> index 1c29bce..74dbdaf 100644
> --- a/tests/tcg/test_path.c
> +++ b/tests/tcg/test_path.c
> @@ -3,6 +3,7 @@
>   #include "util/cutils.c"
>   #include "util/hexdump.c"
>   #include "util/iov.c"
> +#include "util/bufferiszero.c"

This fixes the build, however why not take this opportunity to fix it 
through the Makefile instead of including .c?

Regards,

Phil.

>   #include "util/path.c"
>   #include "util/qemu-timer-common.c"
>   #include <stdarg.h>