Re: [Qemu-devel] [PATCH for-2.10 0/5] tests: acpi: make sure FADT is compared to reference table

[Michael S. Tsirkin]

On Wed, Aug 02, 2017 at 09:51:22AM +0200, Igor Mammedov wrote:
> On Wed, 2 Aug 2017 00:14:18 +0300
> "Michael S. Tsirkin" <address@hidden> wrote:
> 
> > On Mon, Jul 31, 2017 at 05:40:47PM +0200, Igor Mammedov wrote:
> > > While refactoring i386/FADT generation to build_append_int_noprefix()     
> > >        
> > > and testing it, It turned out that FADT is only tested for valid          
> > >        
> > > checksum but actual test for unintended changes isn't applied to it       
> > >        
> > > even though we have reference tables in tree.                             
> > >        
> > > So here goes a couple of cleanups to reflect what fuctions do +           
> > >        
> > > some comments and actual fix.                                             
> > >        
> > >                                                                           
> > >        
> > > Note to maintainer:                                                       
> > >        
> > >   FADT reference table is out of sync and should be updated along with    
> > >        
> > >   series applied.                                                         
> > >        
> > >                                                                           
> > >        
> > > CC: "Michael S. Tsirkin" <address@hidden>                                 
> > >        
> > > CC: Marcel Apfelbaum <address@hidden>   
> > 
> > Absolutely good stuff, but not a bugfix as such (it's not that the
> > test is wrong, it's that we skip FADT for now)
> > so I don't think this is 2.10 material.
> Agreed, it could go in when 2.11 merge window is open.

thanks,pls remember to repost or ping then.

> > 
> > > Igor Mammedov (5):
> > >   tests: acpi: move tested tables array allocation outside of
> > >     test_acpi_dsdt_table()
> > >   tests: acpi: init table descriptor in test_dst_table()
> > >   tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its
> > >     usage
> > >   tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables
> > >     usage
> > >   tests: acpi: fix FADT not being compared to reference table
> > > 
> > >  tests/bios-tables-test.c | 30 ++++++++++++++++++------------
> > >  1 file changed, 18 insertions(+), 12 deletions(-)
> > > 
> > > -- 
> > > 2.7.4