[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 1/5] block: Fix order in bdrv_replace_c
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 1/5] block: Fix order in bdrv_replace_child() |
Date: |
Thu, 3 Aug 2017 10:12:12 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/03/2017 10:02 AM, Kevin Wolf wrote:
> Commit 8ee03995 refactored the code incorrectly and broke the release of
> permissions on the old BDS. Instead of changing the permissions to the
> new required values after removing the old BDS from the list of
> children, it only re-obtains the permissions it already had.
>
> Change the order of operations so that the old BDS is removed again
> before calculating the new required permissions.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH for-2.10 1/5] block: Fix order in bdrv_replace_child(), Kevin Wolf, 2017/08/03
[Qemu-devel] [PATCH for-2.10 5/5] qemu-iotests: Test reopen between read-only and read-write, Kevin Wolf, 2017/08/03
Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 0/5] block: bdrv_reopen() fixes, John Snow, 2017/08/07
Re: [Qemu-devel] [PATCH for-2.10 0/5] block: bdrv_reopen() fixes, Kevin Wolf, 2017/08/08