[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devi
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices |
|
Date: |
Thu, 3 Aug 2017 17:45:17 +0100 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
* Alberto Garcia (address@hidden) wrote:
> On Thu, Jul 13, 2017 at 08:01:16PM +0100, Dr. David Alan Gilbert (git) wrote:
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -4787,8 +4787,8 @@ int main(int argc, char **argv, char **envp)
> > replay_disable_events();
> > iothread_stop_all();
> >
> > - bdrv_close_all();
> > pause_all_vcpus();
> > + bdrv_close_all();
> > res_free();
>
> I haven't debugged it yet, but in my computer iotest 093 stops working
> (it never finishes) after this change.
Yes, I can reproduce that here (I've got to explicitly run 093 - it
doesn't do it automatically for me):
(gdb) where
#0 0x00007feee3780b76 in ppoll () at /lib64/libc.so.6
#1 0x0000564aed293199 in ppoll (__ss=0x0, __timeout=0x0, __nfds=<optimized
out>, __fds=<optimized out>)
at /usr/include/bits/poll2.h:77
#2 0x0000564aed293199 in qemu_poll_ns (fds=<optimized out>, nfds=<optimized
out>, timeout=<optimized out>)
at /home/dgilbert/git/qemu/util/qemu-timer.c:322
#3 0x0000564aed294de1 in aio_poll (address@hidden, blocking=<optimized out>)
at /home/dgilbert/git/qemu/util/aio-posix.c:622
#4 0x0000564aed215924 in bdrv_drain_recurse (address@hidden) at
/home/dgilbert/git/qemu/block/io.c:188
#5 0x0000564aed216345 in bdrv_drain_all_begin () at
/home/dgilbert/git/qemu/block/io.c:353
#6 0x0000564aed2164b9 in bdrv_drain_all () at
/home/dgilbert/git/qemu/block/io.c:382
#7 0x0000564aed1c9b63 in bdrv_close_all () at
/home/dgilbert/git/qemu/block.c:3113
#8 0x0000564aeceb04fe in main (argc=<optimized out>, argv=<optimized out>,
envp=<optimized out>)
at /home/dgilbert/git/qemu/vl.c:4795
Dave
> Berto
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK