[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 24/29] migration: new message MIG_RP_MSG_RESUME_AC
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [RFC 24/29] migration: new message MIG_RP_MSG_RESUME_ACK |
|
Date: |
Fri, 4 Aug 2017 15:23:54 +0800 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Aug 03, 2017 at 12:21:41PM +0100, Dr. David Alan Gilbert wrote:
[...]
> > +static int migrate_handle_rp_resume_ack(MigrationState *s, uint32_t value)
> > +{
> > + trace_source_return_path_thread_resume_ack(value);
> > +
> > + /*
> > + * Currently value will always be one. It can be used in the
> > + * future to notify source that destination cannot continue.
> > + */
> > + assert(value == 1);
>
> Again I prefer the routine to fail than to assert.
> Maybe it's worth having a constant rather than the magic 1.
Will do. Thanks,
--
Peter Xu