[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] QAPI design mistake: RockerPort member @speed shoud bi
|
From: |
Markus Armbruster |
|
Subject: |
[Qemu-devel] QAPI design mistake: RockerPort member @speed shoud bi |
|
Date: |
Fri, 04 Aug 2017 17:03:11 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
RockerPort member @speed is documented to be "in Mbps" (presumably
Megabits/second). It uses QAPI type 'uint32'.
This is inappropriate for QAPI/QMP. It should have been made plain
bits/second (no multiple), and maybe 'uint64'. As far as I can tell,
the QAPI part didn't get review from QAPI experts. Probably because it
wasn't cc'ed to them.
Too late to fix now, but let's not repeat the mistake.
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] QAPI design mistake: RockerPort member @speed shoud bi,
Markus Armbruster <=