Re: [Qemu-devel] [PATCH] pc/acpi: Fix booting of macOS with Clover EFI bootloader

[Dhiru Kholia]

On Sat, Aug 5, 2017 at 2:00 PM, Dhiru Kholia <address@hidden> wrote:
> On Fri, Aug 4, 2017 at 8:44 PM, Igor Mammedov <address@hidden> wrote:
>> On Fri, 4 Aug 2017 16:17:07 +0530
>> Dhiru Kholia <address@hidden> wrote:
>>
>>> On Fri, Aug 4, 2017 at 2:35 PM, Igor Mammedov <address@hidden> wrote:
>>> > On Fri,  4 Aug 2017 12:15:40 +0530
>>> > Dhiru Kholia <address@hidden> wrote:
>>> >
>>> >> This was tested with macOS 10.12.5 and Clover r4114.
>>> >>
>>> >> Without this patch, the macOS boot process gets stuck at the Apple logo
>>> >> without showing any progress bar.
>>> >>
>>> >> I have documented the process of running macOS on QEMU/KVM at,
>>> >>
>>> >> https://github.com/kholia/OSX-KVM/
>>> >>
>>> >> Instead of using this patch, adding an additional command-line knob
>>> >> which exposes this setting (force_rev1_fadt) to the user might be a more
>>> >> general solution.
>>> >
>>> > it's been reported that OVMF had issues that were fixed,
>>> > you probably want to read this thread:
>>> > https://www.mail-archive.com/address@hidden/msg468456.html
>>>
>>> Hi Igor,
>>>
>>> I have now tested various OVMF versions with the latest QEMU (commit
>>> aaaec6acad7c).
>>>
>>> When using edk2.git-ovmf-x64-0-20170726.b2826.gbb4831c03d.noarch.rpm
>>> from [1] macOS does not boot and gets stuck. The CPU usage goes to
>>> 100%. I haven't confirmed this but this OVMF build should have both
>>> 198a46d and 072060a edk2 commits in it, based on the build date.
>>>
>>> The OVMF blob from Gabriel Somlo [2] hangs on the OVMF logo screen and
>>> it too results in 100% CPU usage after hanging.
>>>
>>> I am using "boot-clover.sh" script from my repository [4] to test the
>>> various OVMF versions.
>>>
>>> The only OVMF blob which works with the current QEMU for booting macOS
>>> is the one from Proxmox [3]. Unfortunately, I don't know the
>>> corresponding commit in the edk2 repository for this working OVMF
>>> blob.
>> So it's guest side issue, I'd prefer if it fixed there if possible
>> instead of adding new CLI options to QEMU to work around issue.
>>
>> Added to CC BALATON Zoltan for whom updating OVMF fixed the problem,
>> perhaps you'll be able to figure out what your setup is missing.
>
> I ran git bisect on OVMF repository [5] to find the commit that broke
> booting of macOS + Clover combination in QEMU/KVM.
>
> It seems that commit 805762252733bb is problematic for some reason.
> Reverting this commit fixes the macOS booting problem.
>
> In summary, I am able to boot macOS 10.12.5 + Clover combination with
> latest OVMF (commit 1fceaddb12b with 805762252733bb reverted) +
> updated QEMU (commit aaaec6acad7c with patch from this thread
> applied).

After some more testing,

I am also able to boot macOS 10.12.5 + Clover combination with latest
OVMF (commit 1fceaddb12b with 805762252733bb reverted) + updated QEMU
(commit ac44ed2afb7c60 *without* my patch from this thread).

However, macOS 10.12.5 + older Proxmox OVMF blob doesn't boot with the
same QEMU version without my patch from this thread.

Overall, exposing this (force_rev1_fadt) setting to the user to might
be necessary if maintaining compatibility with older OVMF blobs is
required.

It would be great if someone else could reproduce my results, and
ensure that they are correct.

Thanks,
Dhiru

> I don't know what commit 805762252733bb does yet but I will look at it
> again. I am CC'ing Laszlo Ersek, the author of this OVMF commit.
>
> [5] https://github.com/tianocore/edk2
>
>>> References,
>>>
>>> [1] https://www.kraxel.org/repos/jenkins/edk2/
>>>
>>> [2] https://www.contrib.andrew.cmu.edu/~somlo/OSXKVM/
>>>
>>> [3] https://git.proxmox.com/?p=pve-qemu-kvm.git;a=tree;f=debian
>>>
>>> [4] https://github.com/kholia/OSX-KVM/