[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user |
|
Date: |
Sun, 6 Aug 2017 23:18:46 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 05/08/2017 09:39, Thomas Huth wrote:
>> +CONFIG_VHOST_USER_SCSI=$(and $(CONFIG_VHOST_USER),$(CONFIG_LINUX))
> I have to say that I don't really like using $(and ...) in our makefiles
> like this. You rely on the fact that the config variables are either set
> to "y" or not set at all ... but if somebody ever tries to set
> CONFIG_VHOST_USER=n and CONFIG_LINUX=y for example (which sounds valid,
> too), this will break. Isn't there a better way of checking that both
> variables are set to "y" ?
$(call land, ...) does exactly this.
Paolo