Re: [Qemu-devel] [PATCH 04/17] nbd/client: fix nbd_send_request to return int

[Vladimir Sementsov-Ogievskiy]

07.08.2017 11:23, Daniel P. Berrange wrote:
> On Fri, Aug 04, 2017 at 06:14:27PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > Fix nbd_send_request to return int, as it returns a return value
> > of nbd_write (which is int), and the only user of nbd_send_request's
> > return value (nbd_co_send_request) consider it as int too.
> The real problem here is the return value of nbd_write() - it should be
> a ssize_t, not an int, since it is propagating the return value of
> nbd_rwv() which is ssize_t.

It was changed in f5d406fe86bb (sent in May)
The discussion actually was started half a year ago:
https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg00825.html


> Basically all functions that do I/O and
> return the number of bytes read/written should be ssize_t - any use of
> int is a bug.
>
> Regards,
> Daniel


--
Best regards,
Vladimir