Re: [Qemu-devel] [PATCH v7 1/6] throttle: factor out duplicate code

[Pradeep Jagadeesh]

On 7/10/2017 4:41 PM, Eric Blake wrote:
> On 07/04/2017 10:30 AM, Pradeep Jagadeesh wrote:
> > This patch factor out the duplicate throttle code that was present in
>
> s/This patch factor/Factor/
>
> It's okay to write commit messages in the imperative tense; the easiest
> way I know to start a good message is to use an implied "Apply this
> patch to ..." in front of the sentence.  But "Apply this patch to This
> patch ..." obviously doesn't flow, compared to "Apply this patch to
> factor ..."
OK
> > block and fsdev devices.
> >
> > Signed-off-by: Pradeep Jagadeesh <address@hidden>
> > Reviewed-by: Alberto Garcia <address@hidden>
> > ---
> Reviewed-by: Eric Blake <address@hidden>