[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/9] s390x/ccw: create s390 phb conditionally
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 5/9] s390x/ccw: create s390 phb conditionally |
|
Date: |
Mon, 7 Aug 2017 12:00:27 +0200 |
On Fri, 4 Aug 2017 15:20:26 +0200
David Hildenbrand <address@hidden> wrote:
> On 04.08.2017 13:29, Cornelia Huck wrote:
> > Don't create the s390 pci host bridge if we do not provide the zpci
> > facility.
> >
> > Reviewed-by: Thomas Huth <address@hidden>
> > Acked-by: Christian Borntraeger <address@hidden>
> > Signed-off-by: Cornelia Huck <address@hidden>
>
> This works, because s390_init_cpus(machine) (which sets up features) is
> called before adding the bus. Mind to add a comment so nobody tries to
> reshuffle these functions?
This is already needed by the flic setup (which also relies on the
features being set up). We really want the cpu setup as early as
possible.
Do you have a good comment handy? :)
[Qemu-devel] [PATCH v4 9/9] s390x: refine pci dependencies, Cornelia Huck, 2017/08/04
[Qemu-devel] [PATCH v4 3/9] s390x: chsc nt2 events are pci-only, Cornelia Huck, 2017/08/04
[Qemu-devel] [PATCH v4 1/9] kvm: remove hard dependency on pci, Cornelia Huck, 2017/08/04
[Qemu-devel] [PATCH v4 6/9] s390x/sclp: properly guard pci-specific functions, Cornelia Huck, 2017/08/04
[Qemu-devel] [PATCH v4 7/9] s390x/pci: fence off instructions for non-pci, Cornelia Huck, 2017/08/04